Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment loading upgrades #61

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Environment loading upgrades #61

merged 5 commits into from
Aug 21, 2024

Conversation

zoe-codez
Copy link
Member

@zoe-codez zoe-codez commented Aug 21, 2024

📬 Changes

  • implements env-file flag #52
  • adds parsing for environment sourced values to match more structured stuff

Test command for PR, the test-main may change in the future

TEST_OBJECT_CONFIG="{\"test\":true,\"baz\":123}" npx tsx src/testing/helpers/test-main.ts

2024-08-21_18-16

npx tsx src/testing/helpers/test-main.ts  

2024-08-21_18-16_1

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.85%. Comparing base (3410763) to head (395a582).
Report is 1 commits behind head on main.

Files Patch % Lines
src/helpers/config.helper.ts 96.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   73.37%   74.85%   +1.47%     
==========================================
  Files          30       28       -2     
  Lines        1401     1360      -41     
  Branches      191      188       -3     
==========================================
- Hits         1028     1018      -10     
+ Misses        360      329      -31     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoe-codez zoe-codez merged commit 0ea52ef into main Aug 21, 2024
1 check passed
@zoe-codez zoe-codez deleted the env_file_loading branch August 21, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant